Incorrect use of the @BeforeMethod and @AfterMethods methods

Have a look at this test:

HomePage homepage;
ResultsPage resultsPage;
	
@AfterMethod
public void after() {
  resultsPage.close();
}

@BeforeMethod
public void before() {
  homepage = new HomePage();
  homepage.open();
  assertTrue(homepage.isValidPage());
}

@Test
public void totalPriceTest() {
  homepage.typePostalCode(postalCode);
  homepage.selectRadius(radius);
  homepage.selectNearlyNew(selectNearlyNew);
  homepage.selectNew(selectNew);
  homepage.selectMake(make);
  homepage.selectModel(model);
  homepage.selectTotalPrice();

  resultsPage = homepage.submitSearch();

  assertTrue(resultsPage.isValidPage());
  assertTrue(resultsPage.countContains(homepage.searchCount()));
  assertTrue(resultsPage.isRadiusSelected(radius));
  assertTrue(resultsPage.isPostalCode(postalCode));
  assertTrue(resultsPage.isMakeSelected(make));
  assertTrue(resultsPage.isModelSelected(model));

  assertTrue(resultsPage.carFiltersContain(homepage.selectedCarFilters()));

  resultsPage.selectTotalPriceLowest();
  assertTrue(resultsPage.isSortOrderDescending(false));
}

The test uses a home page that is opened in some way.

In the homepage, multiple fields are populated and then a search is executed.

The test then continues using a results page.

The before() method creates the home page object, opens the home page and checks if it is displayed.

The after() method closes the results page.

The before() and after() methods works for a test that starts on the home page and ends on results page.

But what if we have a test that starts on the home page and ends on details page?

Or starts on the login page and ends on the checkout page?

Because before() opens the home page, all tests must start with the home page.

Because after() closes the results page, all tests must end on the results page.

This is too restrictive and should be avoided by removing any page objects from both test fixture methods (before() and after()).

Lets remember that before() and after() methods should just prepare the test environment so the tests can run in it and clear the test environment after the tests dont need it any longer.

Opening a home page means starting to interact with the application.

All interaction with the application should be in the test method.

before() and after() are test fixtures.

This is what they should do:

A test fixture is a fixed state of a set of objects used as a baseline for running tests. The purpose of a test fixture is to ensure that there is a well known and fixed environment in which tests are run so that results are repeatable. Examples of fixtures:

Preparation of input data and setup/creation of fake or mock objects;

Loading a database with a specific, known set of data;

Copying a specific known set of files creating a test fixture will create a set of objects initialized to certain states.

from https://github.com/junit-team/junit4/wiki/test-fixtures